Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bind address for consul checks #1866

Merged
merged 8 commits into from
Oct 27, 2016
Merged

Use bind address for consul checks #1866

merged 8 commits into from
Oct 27, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 26, 2016

Fixes #1574

Thank you @evan2645 for the original PR #1600

@@ -33,6 +33,10 @@ type ConsulConfig struct {
// services with Consul.
AutoAdvertise bool `mapstructure:"auto_advertise"`

// ChecksUseAdvertise specifies that Consul checks should use advertise
// address instead of bind address
ChecksUseAdvertise bool `mapstructure:"checks_use_advertise"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the list of valid tags in config_parse.go

@dadgar dadgar merged commit 4fc7e30 into master Oct 27, 2016
@dadgar dadgar deleted the f-bind-addr branch October 27, 2016 18:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants